[ViX_Misc] EPG Refresh, iEPG and VPS

[ccs]

Here's a Modifications.py with the intercepts coded such that they can handle any caller. (I think).

(attachment removed - I spotted an error...)

I can't download the current plugin to put it into it as:

EDIT: Fixed that. Had to do an update first....but the files are compiled in it and these are arch-specific(?) so I can't just replace the *.pyo file there.

I didn't spot you spotting an error.

The settings restore now works ok, but epg/green causes a crash, you probably know already..

<    46.2044> 18:39:50.1219 [InfoBarGenerics] Key: 399 (Break) KeyID='KEY_GREEN' Binding='('GREEN',)'.
<    46.2045> 18:39:50.1220 [ActionMap] Keymap 'ColorActions' -> Action = 'green'.
<    46.2183> 18:39:50.1358 Traceback (most recent call last):
<    46.2183> 18:39:50.1358   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
<    46.2186> 18:39:50.1361   File "/usr/lib/enigma2/python/Screens/UserDefinedButtons.py", line 30, in keypressHandler
<    46.2187> 18:39:50.1362   File "/usr/lib/enigma2/python/Screens/EpgSelectionBase.py", line 359, in addEditTimer
<    46.2189> 18:39:50.1364   File "/usr/lib/enigma2/python/Screens/TimerEntry.py", line 286, in addTimerFromEvent
<    46.2191> 18:39:50.1366   File "/usr/lib/enigma2/python/mytest.py", line 324, in openWithCallback
<    46.2193> 18:39:50.1368     dlg = self.open(screen, *arguments, **kwargs)
<    46.2193> 18:39:50.1369   File "/usr/lib/enigma2/python/mytest.py", line 334, in open
<    46.2195> 18:39:50.1371     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
<    46.2196> 18:39:50.1371   File "/usr/lib/enigma2/python/mytest.py", line 271, in instantiateDialog
<    46.2198> 18:39:50.1373     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
<    46.2198> 18:39:50.1373   File "/usr/lib/enigma2/python/mytest.py", line 294, in doInstantiateDialog
<    46.2200> 18:39:50.1376     dlg = screen(self, *arguments, **kwargs)
<    46.2201> 18:39:50.1376   File "/usr/lib/enigma2/python/Screens/TimerEntry.py", line 23, in __init__
<    46.2202> 18:39:50.1377   File "/usr/lib/enigma2/python/Screens/TimerEntryBase.py", line 20, in __init__
<    46.2203> 18:39:50.1378   File "/usr/lib/enigma2/python/Screens/Setup.py", line 44, in __init__
<    46.2205> 18:39:50.1380   File "/usr/lib/enigma2/python/Plugins/SystemPlugins/vps/Modifications.py", line 191, in new_TimerEntry_createSetup
<    46.2214> 18:39:50.1389     self._createSetup_old_rn_vps(*args, **kwargs)
<    46.2215> 18:39:50.1390 NameError: global name 'args' is not defined
<    46.2215> 18:39:50.1391 [ePyObject] (CallObject(<bound method HelpableActionMap.action of <Components.ActionMap.HelpableActionMap instance at 0xb0e799e0>>,('ColorActions', 'green')) failed)

 

[birdman]

I'm only trying to fix the crash. Which occurs as the plugin code expects the enigma2 code to be using a specific API, and it can't cater for any change to this (although it should, and can).

There is some attempt to do this in both the Vix and PLi plugin, but they've both just hardwired specific hacks to one specific call rather than generalizing everything.

Here are versions which I think should fix the crash for both the Vix and PLi version of the plugin.

But it would help if there were some agreement on which should be used, and the other one to be deleted (to avoid further confusion).

PLi plugin: View attachment Modifications.py

Vix pugin: Updated, see: https://www.world-of-satellite.com/...h-iEPG-and-VPS&p=509007&viewfull=1#post509007

 

[ccs]

I thought the last version fixed the crash? Anyway, I'll try again later this evening when recordings are finished.

 

[birdman]

I thought the last version fixed the crash?

That was the intent, but I forgot to edit one line.

 

[Joe_90]

To update,while adding a timer presents the VPS option and appears to let you select yes and save, if you subsequently edit the timer then the VPS option hasn't been saved.

Sent from my IN2013 using Tapatalk

I was getting the same issue. It looked like I was selecting VPS=yes on the timer edit and saving with GREEN as usual, but looking at the timer subsequently the setting was =no.

 

[ccs]

I'm only trying to fix the crash. Which occurs as the plugin code expects the enigma2 code to be using a specific API, and it can't cater for any change to this (although it should, and can).

There is some attempt to do this in both the Vix and PLi plugin, but they've both just hardwired specific hacks to one specific call rather than generalizing everything.

Here are versions which I think should fix the crash for both the Vix and PLi version of the plugin.

But it would help if there were some agreement on which should be used, and the other one to be deleted (to avoid further confusion).

PLi plugin: View attachment 61410

Vix pugin: View attachment 61411

ViX version works fine doing a settings restore, and there is no longer a crash in epg/green mentioned in post #181.

VPS option shows in timers and autotimers.

Selecting VPS=yes still gets lost after saving.

Based on a bog standard 5.4.005

 

[birdman]

ViX version works fine doing a settings restore

Good news, thanks

, and there is no longer a crash in epg/green mentioned in post #181.

That was my fault (and why I removed the original).

Selecting VPS=yes still gets lost after saving.

Since the crash is fixed I may look at that next.

 

[Huevos]

I'm only trying to fix the crash. Which occurs as the plugin code expects the enigma2 code to be using a specific API, and it can't cater for any change to this (although it should, and can).

There is some attempt to do this in both the Vix and PLi plugin, but they've both just hardwired specific hacks to one specific call rather than generalizing everything.

Here are versions which I think should fix the crash for both the Vix and PLi version of the plugin.

But it would help if there were some agreement on which should be used, and the other one to be deleted (to avoid further confusion).

PLi plugin: View attachment 61410

Vix pugin: View attachment 61411

No point doing anything with the PLi plugin because we are OE-A and build from our repos.

 

[Huevos]

Gordon, you have removed P3 compatibility. This plugin is used in P3 images.

 

[birdman]

Gordon, you have removed P3 compatibility. This plugin is used in P3 images.

Not knowingly. All I've done is make the call interceptions totally generic (in that they can handle being called with any args).

What is the actual issue?

 

[birdman]

No point doing anything with the PLi plugin because we are OE-A and build from our repos.

OK; but I was asked to do so, so someone here is using the PLi version.

 

[birdman]

Selecting VPS=yes still gets lost after saving.

OK. I've actually installed the plugin (but, from what I've picked up in the past it will be of no use to me as Freeview doesn't send the expected signals?).

Now sure what you mean by "setting VPS=yes".

I can see "Enable VPS plugin" (which is on by default) and "VPS enabled by default" (which is No by default).

Ah!!! I see.

If you disable the plugin, that works. But you then can't turn it back on!!!
Should be simple to track that down (hopefully...)

 

[birdman]

Forcing the config.plugins.vps.enabled setting to be written out whatever its value fixes the issue.

Not sure that this should be required, but if you drop this plugin.py in place it will at least let it be switched back on.

View attachment plugin.py

 

[Huevos]

Not knowingly. All I've done is make the call interceptions totally generic (in that they can handle being called with any args).

What is the actual issue?

Well done for making progress with this. Re: P3 I was talking about removal of absolute import.

Once this is working someone needs give it a test in P3 (maybe Twol).

 

[abu baniaz]

Plugin "version number" is a subjective thing as that is based on the repo that it is built from. As we use boxbranding, the two versions are going to be different. If anybody is using a PLI version on our Distro, they are confusing things. Please don't spend your time trying to fix the PLI version. Ideally, we should add the fixes/improvements from PLI to our version. And send our fixes to PLI too. There haven't been any functional changes to our version since 2013

The commit histories are:

PLI
https://github.com/OpenPLi/enigma2-plugins/commits/master/vps

OE-A images
https://github.com/oe-alliance/enigma2-plugins/commits/master/vps

 

[birdman]

Well done for making progress with this. Re: P3 I was talking about removal of absolute import.

Nothing to do with me. All I changed was a set of def () statements (and the calls to their intercepted originals) and removed a bit of code that was no longer necessary.
No changes at all to any imports.
So if P3 has a problem with them I'd need to know which they are to see what the problem might be.

EDIT: By P3 do you mean Python3? I was going to look at that, but I've done nothing that isn't Py3 compatible.
(I did remove an attempted import of six, as the associated hack is no longer required).

 

[birdman]

Please don't spend your time trying to fix the PLI version. Ideally, we should add the fixes/improvements from PLI to our version.

That was basically what I was going to do.
(Although originally all I was going to do was to fix the fact the code couldn't handle the "justLoad" optional parameter.)

So if anyone knows of anything that the PLi code can do that the Vix code doesn't it would help me whilst I look.

 

[birdman]

Turns out the code I put in for the optional widget parameter in the new_TimerEntry_createSetup() function was wrong.
Oddly, thanks to Pythons bizarre mixing of its two parameter passing methods, it would actually work. Not sure that Vix ever sends one anyway (PLi does, but it always sends it).

I also notice that the Information screen doesn't actually show all of the text that it should (is there a length/line limit to a ScrollLabel() text?).
And the part that gets chopped off is quite important...

 

[Huevos]

Gordon, my mistake. I was diffing against the Dev branch.

 

[Huevos]

Turns out the code I put in for the optional widget parameter in the new_TimerEntry_createSetup() function was wrong.
Oddly, thanks to Pythons bizarre mixing of its two parameter passing methods, it would actually work. Not sure that Vix ever sends one anyway (PLi does, but it always sends it).

I also notice that the Information screen doesn't actually show all of the text that it should (is there a length/line limit to a ScrollLabel() text?).
And the part that gets chopped off is quite important...

Info screen works for me.

Can you post your updated version please.