[ABM-DVB-S/S2] "London Live" on Sky UK provider

[Huevos]

So how do you want to handle that?

 

[Joe_90]

If your argument is: This is no good for people using FTA, so pointless adding it. If so, I would point out that the service will be omitted if FTA scan mode was used. And the fact that the hack is already in the file is being ignored. I suppose best we remove the hack and who want it can add it on their personal file.

abu - if the channel is omitted in an ABM FTA "scan", then fine - it's not affecting FTA users. I thought maybe it was being added into the normal ABM mix.

 

[BrokenUnusableAccount]

So how do you want to handle that?

If just changeing where the original code said "117" to "173" is unacceptable I don't think I'm going to be able to come up with anything.

 

[Huevos]

abu - if the channel is omitted in an ABM FTA "scan", then fine - it's not affecting FTA users. I thought maybe it was being added into the normal ABM mix.

It is being added in the normal mix along with all the other encrypted channels that still open with a subscription card.

 

[Huevos]

If just changeing where the original code said "117" to "173" is unacceptable I don't think I'm going to be able to come up with anything.

What are the 3 most important things...? Delete, delete, delete.

 

[BrokenUnusableAccount]

What are the 3 most important things...? Delete, delete, delete.

I don't understand.
Are you angry?
Just reminding me that the deletions that have been done since my original post would have to be undone?

 

[Huevos]

Brian, some people delete things while the discussion is still ongoing. Obviously the discussion part of the process is irrelevant to them.

 

[abu baniaz]

I have reverted the removal..

 

[Huevos]

So Brian you are free to send a pull request (as long as you test first).

 

[Huevos]

I have reverted the removal so that some people can continue to say that this should be in a mix file and also reject conditonalising the insert. We have yet to hear "ABM should be making bouquets exactly as per Provider order".

That is what Satscan test tool does, so if anyone is not happy with what ABM produces they can use that tool.

 

[BrokenUnusableAccount]

So Brian you are free to send a pull request (as long as you test first).

Well I already tried it both in London and outside London.

Adu seems to think it need to be conditional.

How about some further explanation of so I can understand these two thoughts.

 

[abu baniaz]

What is end result of what you want to achieve?

 

[Huevos]

So in London region you want it in its 117 slot. 173 slot is already populated with BBC3.
For other regions it should drop in 173 if vacant, and BBC3 will be in slot 173.

Is that what happens in testing?

 

[BrokenUnusableAccount]

So in London region you want it in its 117 slot. 173 slot is already populated with BBC3.
For other regions it should drop in 173 if vacant, and BBC3 will be in slot 173.

Is that what happens in testing?

Yes it is.

 

[Huevos]

Might as well send a PM then.

 

[BrokenUnusableAccount]

For other regions it should drop in 173 if vacant, and BBC3 will be in slot 173.

Correction "BBC Three" will be in 117.
But I think that's what you meant.

 

[BrokenUnusableAccount]

I propose the variable should be called "channels_to_add_by_name" should it be re-added.

Shall I change the name too?
channels_to_add_by_name does seem like a better name.

 

[abu baniaz]

If you do it, do it as two commits.

 

[BrokenUnusableAccount]

If you do it, do it as two commits.

Did you delete the original logic because you were hoping I'd re-do it with different logic?

 

[abu baniaz]

I deleted the code that was not being used in the hack section. I believe they call it code rot. We would have added it back when next required.

I have removed the alleged user hack since conditionalising the hack to apply if not in London has been rejected.

I propose the variable should be called "channels_to_add_by_name" should it be re-added.

Do what you think benefits most people most.

You also have to bear in mind that on an SD lineup, Sky don't really care/need to bother about the numbers for HD channels as the HD channels can't be viewed on SD boxes. It took quite a few years to get the Custom version of HD areas although one of the original suggestions was we add an option for "Custom mode" for Sky providers. Obviously that would mean slight changes to the code in provider files to detect "custom mode" and would need to gradually wean people away from selecting regions ending in "custom" and toggle the option instead. Then the eventual removal of Custom areas. I digress.

Anyway, the way to do what you are working on for BBC Three/London Live is
Define what you want to achieve. (I asked this in post 32, although most of it is in the first post)
Remove hacks affecting situation (In this case, the 117 hacks needs to be removed)
Run ABM for various areas. SD and HD regions. Scotland, Wales, NI and a couple of areas in England. Also RoI
Tabulate your data, you can then workaround the situation and do what works best.

Which area are you in?