Some ideas to improve the Graphical EPG screen

[dsayers]

This has been talked about for a very long time and a very popular addition but ultimately without success when having Vix adopt this.

ATV did commit the pull requests I did for first half of epg mod. I then got side tracked and forgot about remainder.

I did try adding guide-list bouquets a few years ago but the commit was rejected and they wanted a previous bouquet tab showing but I couldnt work it out.

Could you possibly look at adding them to ViX?

I tried here https://github.com/davesayers2014/enigma2-1/commit/73aaf44ecd3a76f2e4076d6e5610e155cdee44f0

But I get crash

< 44197.086> Traceback (most recent call last):
< 44197.086>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 51, in action
< 44197.203>   File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 104, in okbuttonClick
< 44197.203>   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1583, in openBouquetEPG
< 44197.203>   File "/usr/lib/enigma2/python/mytest.py", line 320, in openWithCallback
< 44197.204>     dlg = self.open(screen, *arguments, **kwargs)
< 44197.204>   File "/usr/lib/enigma2/python/mytest.py", line 330, in open
< 44197.204>     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
< 44197.204>   File "/usr/lib/enigma2/python/mytest.py", line 267, in instantiateDialog
< 44197.204>     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
< 44197.204>   File "/usr/lib/enigma2/python/mytest.py", line 290, in doInstantiateDialog
< 44197.204>     dlg = screen(self, *arguments, **kwargs)
< 44197.204>   File "/usr/lib/enigma2/python/Screens/EpgSelection.py", line 99, in __init__
< 44197.204>     self.RefreshColouredKeys()
< 44197.205>   File "/usr/lib/enigma2/python/Screens/EpgSelection.py", line 1660, in RefreshColouredKeys
< 44197.206>     if config.epgselection.graph_red.value == "24plus":
< 44197.206>   File "/usr/lib/enigma2/python/Components/config.py", line 1889, in __getattr__
< 44197.206> AttributeError: graph_red
< 44197.206> [ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap instance at 0x9ec5a198>>,('OkCancelActions', 'ok')) failed)

It would be good if you can add ch+ and ch - minus too.


Crash log attached.

The options ought to be added to button setup/hotkey

What would be bad with adding to EPG menu?

 

[birdman]

What would be bad with adding to EPG menu?

Given that they aren't meant to be global keybindings (the idea is for them to be EPG-specific) - I would say, "Nothing".

 

[birdman]

I tried here https://github.com/davesayers2014/enigma2-1/commit/73aaf44ecd3a76f2e4076d6e5610e155cdee44f0

Long series of if tests always give the impression that the coding could be simplified.
If nothing else, 8 if tests in a row for the same value should be replaced by 1 if and 7 elifs, as it can only have one of the values at a time.

e.g.:

#!/usr/bin/python
#

class FuncMap(dict):
    def __missing__(self, key):
        return None

RGYBKeyMap = FuncMap()
RGYBKeyMap = {
   "24plus": "self.nextService()",
   "24minus": "self.prevService()",
   "timer": "self.RecordTimerQuestion(True)",
   "imdb": "self.openIMDb()",
   "autotimer": "self.addAutoTimer()",
   "bouquetlist": "self.Bouquetlist()",
   "epgsearch":  "self.openEPGSearch()",
   "showmovies": "self.showMovieSelection()",
   "record": "self.RecordTimerQuestion()",
   "gotodatetime": "self.enterDateTime()",
}

for graph_yellow in ("24plus", "autotimer", None, "gotodatetime"):
    if graph_yellow:
        to_call = RGYBKeyMap[graph_yellow]
    else:
        to_call = "self.openEPGSearch()"
    if not to_call:     # Set default
        to_call = "self.openEPGSearch()"
    print graph_yellow, "maps to function", to_call

 

[dsayers]

Looks like I missed a few of bbbuk commits https://github.com/davesayers2014/enigma2-1/commit/68fac5abd1543c60a33d5dc48b6b5310f7bb7ea4

Only issue I had to # #self['dialogactions'] lines.

 

[birdman]

Looks like I missed a few of bbbuk commits https://github.com/davesayers2014/enigma2-1/commit/68fac5abd1543c60a33d5dc48b6b5310f7bb7ea4

Which has one array repeated 4 times.
Just create it once and use it 4 times...

 

[dsayers]

Which has one array repeated 4 times.
Just create it once and use it 4 times...

Thanks ill take a look when I get chance.

 

[bbbuk]

Given that they aren't meant to be global keybindings (the idea is for them to be EPG-specific) - I would say, "Nothing".

Unfortunately, it was overuled by some in Vix!

If I remember correctly there was even a poll and it was very popular but thread was ultimately closed.

I do know there is at least one member who did try to keep mod upto date with changes within Vix.

 

[abu baniaz]

What would be bad with adding to EPG menu?

It was discussed, as a team, the decision was no.

It is definitely bad hacking out code that has been added to the image instead of adapting code. All images allow users to select bouquets within the G-EPG. It is the TV button on OEA images. PLI uses bouquet/Ch+/-

bbbuk always used to add debug to indicate it was his file in use. Saved so much messing around with identifying issues.

 

[EGGMANCAN]

Can we change "Add Timer" to "Record" and "Add AutoTimer" to "Record Series"? for regular users who are used to regular boxes coming to OpenViX is a big leap to take. How would a regular user know what Add AutoTimer means?

 

[ccs]

Can we change "Add Timer" to "Record" and "Add AutoTimer" to "Record Series"? for regular users who are used to regular boxes coming to OpenViX is a big leap to take. How would a regular user know what Add AutoTimer means?

You've already had answers to the same question you asked a few days ago.

"timers" have always been used for recordings for as long as I can remember.

I used to have a Sony C9 Betamax recorder.... 1982 Review... "From the consumer point of view the C9 is a stylish front loading machine which has a 9 event 14 day timer...".

 

[adm]

How would a regular user know what Add AutoTimer means?

Autotimer doesn't mean just record a series! It can be used to search for a programme name that hasn't appeared in your EPG yet, perhaps in 3 to 6 months time. Also Add Timer can be used to record a series (if episodes are reapeated an the same time daily/weekly)

Like most boxes I've owned some of the terminolgy is different to what I've owned previously but I've soon got used to the functionality of a new box and the terminology it uses. For instance on a previous (non Enigma2/Openvix) box similar functionality was referred to as PowerSearch, SeriesSearch and TextSearch. All 3 could be used to automatically set timers in the future and 2 modes allowed recording a series). Autotimer contains the functionality of most of the PowerSearch and TextSearch. Series search on my previous box used a facility not available in Openvix. OpenVix already has a "record" function and a Power timer, albeit the latter is not necessarily related to recording programmes.

Add Autotimers can be much more powerfull than the simple "Record Series" as implemented on lesser Freeview/Freesat branded boxes.

 

[EGGMANCAN]

Autotimer doesn't mean just record a series! It can be used to search for a programme name that hasn't appeared in your EPG yet, perhaps in 3 to 6 months time. Also Add Timer can be used to record a series (if episodes are reapeated an the same time daily/weekly)

Like most boxes I've owned some of the terminolgy is different to what I've owned previously but I've soon got used to the functionality of a new box and the terminology it uses. For instance on a previous (non Enigma2/Openvix) box similar functionality was referred to as PowerSearch, SeriesSearch and TextSearch. All 3 could be used to automatically set timers in the future and 2 modes allowed recording a series). Autotimer contains the functionality of most of the PowerSearch and TextSearch. Series search on my previous box used a facility not available in Openvix. OpenVix already has a "record" function and a Power timer, albeit the latter is not necessarily related to recording programmes.

Add Autotimers can be much more powerfull than the simple "Record Series" as implemented on lesser Freeview/Freesat branded boxes.

and how did you discover this new terminology? how did you find out for yourself what AutoTimer means?

 

[birdman]

and how did you discover this new terminology? how did you find out for yourself what AutoTimer means?

Personally, by clicking on the button and seeing what the options were. Then it was obvious what it was.

 

[EGGMANCAN]

Autotimer doesn't mean just record a series! It can be used to search for a programme name that hasn't appeared in your EPG yet, perhaps in 3 to 6 months time. Also Add Timer can be used to record a series (if episodes are reapeated an the same time daily/weekly)

Like most boxes I've owned some of the terminolgy is different to what I've owned previously but I've soon got used to the functionality of a new box and the terminology it uses. For instance on a previous (non Enigma2/Openvix) box similar functionality was referred to as PowerSearch, SeriesSearch and TextSearch. All 3 could be used to automatically set timers in the future and 2 modes allowed recording a series). Autotimer contains the functionality of most of the PowerSearch and TextSearch. Series search on my previous box used a facility not available in Openvix. OpenVix already has a "record" function and a Power timer, albeit the latter is not necessarily related to recording programmes.

Add Autotimers can be much more powerfull than the simple "Record Series" as implemented on lesser Freeview/Freesat branded boxes.

how can you know what the programme title is going to be 3 to 6 months in advance?

The Power timer only works when a channel is being watched. If the EPG, settings or a plugin is open then the Power timer does nothing.

 

[EGGMANCAN]

Personally, by clicking on the button and seeing what the options were. Then it was obvious what it was.

you sure about that?

 

[Willo3092]

how can you know what the programme title is going to be 3 to 6 months in advance?

I often leave my autotimers in place after a series has finished. It will automatically pick up the next series without having to bother.

 

[ccs]

I often leave my autotimers in place after a series has finished. It will automatically pick up the next series without having to bother.

And if there's something you've missed, you can set up an autotimer to record it the next time it's broadcast. Simple.

 

[birdman]

The Power timer only works when a channel is being watched. If the EPG, settings or a plugin is open then the Power timer does nothing.

The reference to a PowerSearch (on a different box) is nothing to do with a Power Timers, which in turn has nothing to do with recording,.

 

[birdman]

you sure about that?

Yes, I'm certain.

 

[EGGMANCAN]

I often leave my autotimers in place after a series has finished. It will automatically pick up the next series without having to bother.

if the events start at the same time in the next series. that would probably work for coronation street idk about every series. It's nice to know that it might catch it if you do miss the start of the next series though.