EPG files test: Phase 1. Refactor

[simonc]

Here's the open bouquet list split back out into its original setting. I think it makes more sense this way anyway, one setting for what to select in the EPG, another for whether to show the bouquet popup

 

[ccs]

Thanks, up and running ok, and much "tidier".

 

[simonc]

I've spotted a bug in EPG Search with the new EPG. Press green to edit a timer when in EPG Search and the menu doesn't go away. It's an easy fix, but I think EPG Search needs a bit more testing. If anyone makes regular use of it, let me know if you spot any other quirks.

 

[abu baniaz]

I personally don't use these but I was under the impression that when this new EPG re-write is introduced it was going to be a seamless introduction (at least as far as end-user is aware).

Yes, that is still the intention and goal. As you can see from the commit to reverse the change, there was a backward compatibility. The permutations of options and preferances are too many to get it right 100%. So far, the reproducable issues raised have been tended to. Including the picons in the timer list (albeit in another branch). Only thing remaining was the Kiddac plugin and help button which we cannot reproduce.
https://github.com/SimonCapewell/enigma2/commit/6b77a06d8b66c5eb60b143ec97a6523d1d6c828f

 

[bbbuk]

I've spotted a bug in EPG Search with the new EPG. Press green to edit a timer when in EPG Search and the menu doesn't go away. It's an easy fix, but I think EPG Search needs a bit more testing. If anyone makes regular use of it, let me know if you spot any other quirks.

Using 027 of vix with latest test EPG files, I also had issue with menu doesn't close.

However, I was also able to make it crash by setting a timer as u mentioned via EPG Search and then trying to delete said timer but this looks like it's related to menu so maybe once this menu option is fixed, it will prevent the crash.

< 63255.0452> 15:38:40.3030 [eEPGCache] FS subtable (6016cc00) version changed (6) now/next (1)
< 63255.1441> 15:38:40.4019 [eInputDeviceInit] 0 67 1
< 63255.1449> 15:38:40.4027 [InfoBarGenerics] KEY: 103 UP
< 63255.6980> 15:38:40.9558 [eInputDeviceInit] 1 160 1
< 63255.6989> 15:38:40.9566 [InfoBarGenerics] KEY: 352 OK
< 63255.6993> 15:38:40.9571 [ActionMap] Keymap 'WizardActions' -> Action = 'ok'.
< 63255.6997> 15:38:40.9575 Traceback (most recent call last):
< 63255.6998> 15:38:40.9575   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 77, in action
< 63255.7001> 15:38:40.9579   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
< 63255.7003> 15:38:40.9581   File "/usr/lib/enigma2/python/Screens/ChoiceBox.py", line 208, in go
< 63255.7007> 15:38:40.9585   File "/usr/lib/enigma2/python/Screens/ChoiceBox.py", line 216, in goEntry
< 63255.7009> 15:38:40.9587   File "/usr/lib/enigma2/python/Screens/EpgSelectionBase.py", line 305, in removeChoiceBoxCB
< 63255.7015> 15:38:40.9593     self.closeChoiceBoxDialog()
< 63255.7017> 15:38:40.9594   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 358, in closeChoiceBoxDialog
< 63255.7020> 15:38:40.9598 AttributeError: 'EPGSearch' object has no attribute 'ChoiceBoxDialog'
< 63255.7022> 15:38:40.9600 [ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap instance at 0x5fce4e18>>,('WizardActions', 'ok')) failed)

Other than EPGSearch, i've not noticed anything else in my normal usage :thumbsup:

 

[simonc]

Yes, that's the troublesome menu, so it's looking pretty solid at the moment

 

[simonc]

Here's the menu fix

View attachment epg_refactor_20200503_1848.zip

 

[ccs]

Installed and running ok - no menu hanging around or subsequent crash.

 

[bbbuk]

Yep, agree with @ccs, no left-over menu or crash. Tried editing/deleting timers created via EPGSearch.

Tried both timers and AutoTimers and no issues :thumbsup:

 

[ccs]

Installing the latest mods results in Show bouquets on launch being set to no, even though it was set to yes before updating.

Started from scratch to double check.

 

[abu baniaz]

Thanks for reporting

https://github.com/SimonCapewell/enigma2/pull/7

 

[ccs]

Thanks, Show bouquets on launch now working as expected.

 

[abu baniaz]

New files uploaded to post 2 following the rebase. One last push of testing please and then that's it until the code is merged.


Then the next phase starts
:sofahide:

 

[dsayers]

I get the issues with help arrows described by @Huevos on post on post 6 apart from that and catchup on jedimakerxtream everything else seems fine.

 

[ccs]

Installed and running fine.

 

[Huevos]

I think you should get on and commit this. At least it would be available to all running a Dev build then. Personally I have had no issues so far. I haven't been actively looking for bugs but at the same time I haven't noticed any weird behaviour. Code has been running on the family box for several weeks.

 

[bbbuk]

I've not noticed any issues for our normal usage and bit of extra things been playing with to see if it crashes :thumbsup:

 

[kiddac]

Jeewhizz, what are you guys up to now.
From initially looking at the new files I presume you are just breaking up the massive epgselection.py file into more manageable files.

dsayers I have hacked my JediMakerXtream plugin to work with this new code for catchup. (that was fun). I will post the fix on my normal threads.

I will test all my skins and see if everything is still fine. Quick initial test, I had no problems.

Also for the love of god please don't implement the vertical EPG as found on openatv. God dam awful thing. I always hack that monstrosity out.

 

[simonc]

Yes. Primarily we're breaking up the EPG files into something, anything that has less than 4000 lines in it Other highlights are
- More logical names for the EPGs
- More modular config
- Adding bouquet selector to single EPG
- Bug fixes
- EPGSelection/EPGList remain compatible for plugins that use it as a single EPG type view. There may be some bugs here; we'll iron them out as we go. EPGSearch in particular is requiring some extra consideration...

Other things in the pipeline
- A picon-able number zap in the single EPG (haven't done the skin updates for this yet)
- customisable colour buttons
- partially customisable info, epg, ok
- a toggle feature, so you can set the EPG button (or any other) to rotate around 2 or 3 different EPG views without having to exit all of them at the end of your browsing.
- grid EPG tabs have been requested

I'm not a huge fan of a vertical EPG view (I'm a grid and single EPG user), so I'm not personally intending to get involved in adding one. At least if new EPG views are added now, they shouldn't pollute the other core views, so as a skin customiser, you'll be able to ignore them much more easily.

 

[Trial]

Hi,
I am using it on my daily box for weeks now and in the last week or 2 no problems. When it is in the dev fork we can also start to translate again. Due to some text changes a bit translation must be done.

Perhaps one idea/wish I have since I switched from Enigma1 to 2. I already looked for it by myself a few years ago but my knowledge about the internals is far to limited for that.

If I press info/EPG, or what you call it, to get information about the current program you can switch between now and next with the direction button. In Enigma1 I could switch through the whole single EPG of that service.

Ralf