VPS geht nicht

[birdman]

I don't wish to appear rude

You're not, so don't worry.

and it remains fact that up until 5.4.x VPS 1.3 did not have these issues

Quite possibly.
All I meant was that i can't find any code that would have put it it into the menu.
But if it was there, it was there and I'm not looking in the right place, or hard enough, or hard enough.

 

[birdman]

It was this commit I was trying to exclude from the equation....

https://github.com/oe-alliance/enigma2-plugins/commit/d6c0614d4800e21eaa1217f7f6813914991393e2#diff-acb2a8e7c90345f066d741fc839397cd3c3eca93d364bb344f324ec6bd478890

That doesn't change any functionality. It just "corrects" parameter passing so that it works on ATV and Vix.

However, its possible that the changes in Vix(?) which led to it being required might have caused a difference.

 

[Joe_90]

Good detective work ccs! Maybe that commit broke the compatibility with the manual timer while fixing the boot loop issue? In which case, this info needs to be moved into the main VPS thread as it may get lost here.

 

[ccs]

.... early days yet.

This is the bootloop thread .... https://www.world-of-satellite.com/...01-VPS-plugin-Bootloop&highlight=vps+bootloop

which has a reference to this commit....

https://github.com/OpenViX/enigma2/commit/468bd9cbfadd69d4138aac2b4fd8bfc12d4b3821

 

[Joe_90]

I read that thread at the time and referenced it subsequently but I had never used (or heard of!) VPS before that. There has been a lot of work done on menus and cleaning up code between 5.3 and 5.4, plus the Python 3 stuff which may well have affected the manual timer functionality with VPS.

 

[birdman]

This is the bootloop thread .... https://www.world-of-satellite.com/...01-VPS-plugin-Bootloop&highlight=vps+bootloop

which has a reference to this commit....

https://github.com/OpenViX/enigma2/commit/468bd9cbfadd69d4138aac2b4fd8bfc12d4b3821

And nowhere in that does the text "vps" (in any case) occur, so I can't see that removing anything to do with VPS.

The specific sort of code I'm referring to is code that adds a vps entry to a menu. AutoTimerEntry has it, TimerEntry does not.

 

[ccs]

And nowhere in that does the text "vps" (in any case) occur, so I can't see that removing anything to do with VPS.

The specific sort of code I'm referring to is code that adds a vps entry to a menu. AutoTimerEntry has it, TimerEntry does not.

But that's the commit which caused this vps fix to be needed to prevent the bootloop, mentioned in post #22.

https://github.com/oe-alliance/enigma2-plugins/commit/d6c0614d4800e21eaa1217f7f6813914991393e2#diff-acb2a8e7c90345f066d741fc839397cd3c3eca93d364bb344f324ec6bd478890

All I know is that installing vps creates an extra (vps) option in add timer, all that fails is the save timer, the new option value is lost.

 

[birdman]

But that's the commit which caused this vps fix to be needed to prevent the bootloop, mentioned in post #22.

But "only" because that PR changed the API for a function which the VPS plugin intercepts. So it was now being called with 0 parameters but was defined to expect 1.
Python does not like this.
This PR adds a default one (widget="config") and then checks how many to has to pass to the call it intercepted.
It didn't change any functionality or options in menus.

 

[ccs]

@goRt

On 5.3.xxx does enabling VPS by default like this...



get passed thru to an epg/green add timer, as I'm not seeing it...

 

[ronand]

I have been testing 5.3 briefly. ADD TIMER from epg does work - although with a bit of a fudge. VPS Enabled by Default doesn't seem to stick as already noted. When you enable it manually in the new timer entry the VPS check fails (because the flag is not there) and it sets it as YES (SAFE MODE) which is pointless as the look ahead feature does not kick in. Then you need to change the VPS (Safe Mode) to YES and the VPS recording will function correctly.

 

[ccs]

.... am I right in saying that flashing 5.3.xxx and then installing VPS will get the same version currently on the feeds for 5.4.xxx ??

Or to put in another way, are there still separate plugin feeds for 5.3.xxx ??

I'm not convinced I'm comparing the "working" version in 5.3 with the version in 5.4.

 

[ronand]

Its a separate plugin feed for 5.3

 

[ccs]

Thanks, I've just realised that if I'd looked in SystemPlugins/vps I'd have seen that all the files were created at the same time as the last 5.3 release.

 

[Joe_90]

Its a separate plugin feed for 5.3

But, is it the same VPS plugin code? i.e. - are we encountering changes in both VPS code and manual timer handling in 5.4 or is it just down to menu/timer interface handling in ViX?

edit - or maybe that's what ccs meant (that the VPS files are the same in 5.3 and 5.4)

 

[ccs]

edit - or maybe that's what ccs meant (that the VPS files are the same in 5.3 and 5.4)

That's what I was trying to understand, comparing 5.3 and 5.4 was becoming a nightmare, particularly with gui menu changes added to the equation.

The VPS plugin in 5.4 includes all the recent changes, the plugin files in 5.3 are all dated 19/07/2020.

 

[Joe_90]

Sorry forgot that birdman had edited some of the VPS code to correct parameter handling.

 

[goRt]

@goRt

On 5.3.xxx does enabling VPS by default like this...

View attachment 61512

get passed thru to an epg/green add timer, as I'm not seeing it...

View attachment 61513

Yes, worked without issue on 5.3.xxx
Always set to default full control, turns on/off in manual timers
Displays v1.3 in the about panel.

Sorry for the delay in responding, I don't get notified on this thread (addressing now)

Sent from my IN2013 using Tapatalk

 

[ccs]

Just to be clear, if I create a one off timer in 5.3 with VPS enabled by default (via the plugin men), the initial timer dialogue has VPS set to No, is that what you're seeing?

I'd have expected it to be Yes.

 

[goRt]

Just to be clear, if I create a one off timer in 5.3 with VPS enabled by default (via the plugin men), the initial timer dialogue has VPS set to No, is that what you're seeing?

I'd have expected it to be Yes.

No, with the default set to yes, then VPS is enabled

 

[ccs]

No idea then why I see different, I'll start again from scratch.