Making pull requests of translation files. Advice needed!!

[Kojo_]

Just managed to create my first PR with @Abu´s help to the correct branch. After figuring out how to do that, I would like to ask someone who is familiar with using GITHUB to give us guidelines how to do this properly. Instructions would be nice.

What I did was:
- Created an account to Github
- Searched Enigma2 and Vix repo´s (https://github.com/OpenViX/)
- Clicked "Fork" to be able to upload file to DEV -branch with browser
- After upload, clicked "Create a pull request"

But what about translations for plugins, for example AutoTimer. Where can we find locations for them? Tried searching but didn´t find it.

In the sticky post there is still mentioned that translated files shoud be sent to site admins.

 

[abu baniaz]

You have to submit to the repository that supplies the translation.

You have done the Vix core one. Thanks

AutoTimer is here
https://github.com/oe-alliance/enigma2-plugins/tree/master/autotimer

Others will be here somewhere here:
https://github.com/oe-alliance
https://github.com/oe-alliance/oe-alliance-plugins

If you can't find it/them, on your internet search, use "github oe-alliance (plugin name)"

Once you fork, best to create a new branch which can be deleted afterwards. Keeping your fork in sync using the web is not very well documented. However using applications such as Sourcetree is easier to do.

As you are uploading to the GitHub website, each "transaction" comes up as a commit. When submitting a pull request, they come up with repeat entries. There isn't a way to do it in one go on the website. However, you can edit them. No point having two entries of "Add files via upload ". I have edited the pull requests for you prior to merging the two you have submitted.

 

[abu baniaz]

Another tip for you to consider, when you click on compare and prior to submitting the pull-request, you have opportunity to change the pull request title.

"[Autotimer] Update Finnish translation" is better than

"Add files via upload"

Nothing major, just makes it clearer when people look at the history without checking every commit.
https://github.com/oe-alliance/enigma2-plugins/commits/master