[OS-mini] Empty buttons (no text) in timer and sanity error views

[kiddac]

try reading the bit where I said I don't disagree with it in principle.

I don't post on this forum, because the mods create a hostile environment as proven in the past few posts of this thread. They will not except anything written against their beloved Vix. Not once has anyone said, I understand what you are saying.

And just because I don't post on this forum, doesn't mean the issue doesn't effect me. I have had nothing but mither since this has been brought in, with emails, private messages, forum posts all asking how to fix the skins to work on vix.

 

[rossi2000]

I understand what your saying.

 

[Huevos]

Do these buttons now magically appear. No. Every screen still needs button code in. What are you talking about???

You obviously didn't read Ian's user guide you published on the other forum. The button code is part of the main template imported into almost every screen. That template holds everything that is needed to make the buttons and button texts "magically" appear in each screen. And if the .py changes and different buttons are required that also happens "magically" with any skin edits.

If you look at our skins git you will see where the hundreds of lines have been deleted. Most of the skins that I converted took me about half an hour each, and no button maintenance ever since.

 

[kiddac]

Rossi whether your being sarcastic there or turthfully understanding as you were probably the first to do this conversion, I am sure you will back up the comments that this has caused a right load of trouble.

 

[kiddac]

Huevos everybody designs skins differently. Some people use template files and panels, some people write out the code for every single element in every single screen, vix use a common file. there is not one way of writing a skin. Just because it is easy to convert a vix skin that follows a set format doesn't mean its easy for everyone else to change their skins.

 

[rossi2000]

Of I course I understand, yes I was against them at first, but they were applied anyway, BUT the changes do make things much simpler skinning wise.

I have not checked how you code your skins, whether u use templates or code each screen separately. these changes do work well for templated skins and reduces the needed code, but again depends how your skins are coded initially.

As Huevos pointed out, the Button template can just be added the to the template that draws the screen, (that will check if the screen its displaying needs any buttons and if so displays them) so NO other screen needs buttons adding.

we are in a different situation whereas your skins need to work on multiple images, mine dont.

I guess atm you have 2 options, leave your skins as is, or make a vix skin, a big ballache I know, but realistically theres not much else that can be done at this time dude.

 

[Sicilian]

I don't post on this forum, because the mods create a hostile environment as proven in the past few posts of this thread.

I don't see anything hostile in this thread at all. If a thread becomes hostile report it to me and I'll take a look at it.

 

[Huevos]

@kiddac, our conditional button code is not the reason that you skin is not working right in ViX. That code is completely backwards compatible. Your skin is broken in this screen because it is expecting a Button() object and our enigma uses a StaticText() object.

 

[kiddac]

Just too clarify my situation on this.

I know how to change the buttons to the new format. That isn't a problem

I have read the new button documentation proposal. I fully understand that document.

I fully understand what is trying to be achieved here. Again I don't disagree with it in principle. I disagree with how its been implemented.

In most of my skins it is not a major thing, as I personally use templates. Most of the code is already there.

The problem is (and as Rossi has mentioned above) I try and make my skins work on all builds. Not just openatv, not just vix etc. For as many of the oe-alliance builds as possible. Which to be fair is no easy task, especially as lots of builds have build specifc names and screens. Its taken a long time and a lot of hassle to get the skins in a position where they work on most. (2 years to be precise). Something a lot of skinners don't even try and do because its a nightmare.
If I was only designing for one image in mind, again that is no major problem.

I cannot just change all the button code now, because what would fix one build would break another.

I am not willing to duplicate all my skins to fix this, because I have multiple skins with hd and fhd versions. I am also extremely busy with other projects and life.

I cannot just do one big sweep and change all the button code in every screen, because I skin all the major 3rd party plugins in my skins. And I doubt very much all these plugins are magically going to change soon.
Therefore I would have to individually check each and every screen against the build makers github files just to see who is using what. That is a very long and laborious task. It would be basically like starting from scratch again.

Its easy for someone involved in openvix or a build to amend their skins, because they know what code and components they have changed.
I have no idea what python components Vix have changed until I get message saying your skin is broke I have got no button texts on for example timers. (not that timers are a major fature or anything on these boxes)

So hopefully you can see why I think this is a big deal and a bit of a **** up.

 

[Huevos]

@kiddac, like I said above your skin being broken in OpenViX has nothing to do with wether or not you make changes to take advantage of the button code changes. These are completely backwards compatible.

The reason your skin is not displaying correctly in ViX is because the code is using a StaticText() object and the skin is expecting a Button() object. If you are catering for multiple images, how did you cope with such a thing before? Because that same method is what is needed here.

 

[birdman]

Are you suggesting that our enigma has to remain identical to all other distros so things are easier for skinners?

Only just noticed this.
I smiled at the irony.

 

[kiddac]

Due to the shambolic mess this button code change has caused and 3 months on there is still no universal solution. I no longer will be supporting openvix for any of my skins in the immediate future. You can't just randomly change 10 years of legacy code to suit yourselves.

 

[abu baniaz]

Due to the shambolic mess this button code change has caused and 3 months on there is still no universal solution. I no longer will be supporting openvix for any of my skins in the immediate future. You can't just randomly change 10 years of legacy code to suit yourselves.

I understand what you're saying although you are mistaken.

 

[Huevos]

Still goes back to the same question. If one team use Button() somewhere in their enigma and another team use StaticText(), who is right?

What it looks like is that you want all teams enigma code to not evolve because it might break someone's skin. And the truth is the skin wouldn't be broken if it used the new button bar code.

 

[kiddac]

Who is right? The person who wrote the component in the first place. Who used button(). Therefore every skinner used button().
Who is wrong. The team that decided to change these buttons to statictext, for their own strange reasons????
I have read the huge thread on openpli where this was all initially discussed. Over and over again it mentions you can't break legacy code. So you just went ahead anyway and broke legacy code timers for everyone skin except a handful of vix skins.

https://forums.openpli.org/topic/56924-button-and-label-pli-opinion/

Should we quote your opening paragraph from that thread.

People seem to use these interchangeably and it is a skinner's nightmare

what you have done is now a skinners nightmare. Nobody complained before because it wasn't a problem.

And your alternative solution was to add in an objectypes component that doesn't exist in the first place. So what was the point of that.

Maybe you should just put your hands up and admit you ballsed this up by changing code that wasn't ready to be changed. Change it back to how it was and wait for every other oe-alliance team to implement the changes before commiting to something.

 

[kiddac]

Quote post 44 from Huevos

Why would you want to rename something and break everyone's skins?

 

[ccs]

For those who want to read the whole post, not a snip, and don't want to trawl thru' the thread....

https://forums.openpli.org/topic/56924-button-and-label-pli-opinion/?view=findpost&p=829613

 

[Huevos]

kiddac the objecttypes attribute in skin.py has nothing to do with why your skin is not working properly (in one or two screens) in OpenViX. If you use "source" and render="label" your skin will work fine.

Read post #30 again.

If you don't want to support your users that use OpenViX that's up to you, but stop trying to blame other people.

 

[bbbuk]

I've quickly scanned through this and I'm obviously missing something here!

What I have got so far....

Vix have moved onto StaticText rather than Button.

Apparently, OpenPli and OpenBH have also adopted this too.

Kiddac naturally doesn't want to have a separate skin for vix for which I don't blame him. I doubt many other skin designers would want to go through that trouble and if I did a skin, I would be supporting the majority rather than minority as just easier.

@Kiddac, do your skins have an issue on OpenPLi and OpenBH as they have also adopted this new way as just wondering why PLi and OpenBH don't have this issue?

Or is it because the other image teams that do support new way also support legacy way (for the many, many skins still out there) and Vix doesn't?

 

[Huevos]

Vix have moved onto StaticText rather than Button.

No, ViX uses StaticText() in a few screens that OpenATV don't is the only difference.

But for some reason kiddac wants to blame the new skin attribute "objecttypes" for the problem even though it is not related.

The code is completely backwards compatible. But just the same as before these changes were made a skinner needed to track every screen for changes. Skins that use the new code don't have to track every screen because everything happens automatically.

And by the way PLi have changed from Button() to StaticText() in a lot more screens than ViX has. But at the end of the day it is up to each team how they manage their own enigma2 code, just the same as it is up to every skinner if they want to maintain their skins for all their users, or just some that use one particular image.