Skinning concept

[2stein]

needs some minor formatting adjustments

 

[Huevos]

That is a plugin using its own embedded screen.

 

[DimitarCC]

That screen is missing...Have to be done in the skin. If you can propose a style for that screen, it will be easier for me to add.

 

[Huevos]

@2stein ,

https://github.com/OpenViX/enigma2/blob/Developer/lib/python/Screens/MultiBootSelector.py#L299

Add this change and grab the screen:

- self.skinName = "ChkrootInit"
+ self.skinName = "Setup"

 

[2stein]

well, i would... but the "activate multiboot" selection in the power menu is gone (dont recall what exactly i pressed last time i tried to leave the menu without activating multiboot, i think i pressed deactivate although it was not activated). there is no slot selection either, so multiboot is still disabled.

 

[Huevos]

Maybe you need to reboot

 

[2stein]

Maybe you need to reboot

no, didnt help... in the dreambox multiboot thread i wrote why i think the menu flow conceptually will not work.

 

[Huevos]

i tested it and had to modify the fix to: _(arg[7:].strip())

So this is breaking stuff. Also it can't work reliably because is does not know the formats. e.g.

<convert type="ClockToText">Format: - %H:%M</convert>

 

[2stein]

well, it's not breaking stuff, but it is only a partial solution. "- %sH:%M" is fine at least for german, date formats are more problematic. what would be the alternative?

 

[2stein]

well, it's not breaking stuff, but it is only a partial solution. "- %sH:%M" is fine at least for german, date formats are more problematic. what would be the alternative?

imho there shouldn't be a Format: parameter at all because skins should work for all languages.
or the parameter should be generic like SHORT, MIDDLE, LONG or something.

 

[Huevos]

Format: - %H:%M

It is not fine to drop that because it will break a lot of skins. Also where are we supposed to add the formatting? Like the - and still have translation work?

 

[Huevos]

imho there shouldn't be a Format: parameter at all because skins should work for all languages.
or the parameter should be generic like SHORT, MIDDLE, LONG or something.

So you can add those if you want but it doesn't help where hardcoded formatting is already in use. For the moment I have updated it to just translate the one problematic format string.

 

[2stein]

yes, i know... it would have to be backward compatible. which means, that some skins will display the wrong format and only those where the skinners change to the new concept will be displayed correctly.
the translation would then be done in the components.
e.g. lets say we define a constant MMDDYY which would be used in the skin as "Format: MMDDYY". and in the component we would then translate it:
if format_value = "MMDDYY":
format_string = _("%M/%D/%Y) # use english as default which should already be in the po files and translated by the different languages
as there are so many format combinations we should just define a subset of short, medium, and long formats.
just an idea.

 

[2stein]

not sure though, if it is worth the effort.... if there are a few more problematic formats we could just add them the same way you did.

 

[Joe_90]

Why MMDDYY? Surely DDMMYY for Europe?

 

[2stein]

Why MMDDYY? Surely DDMMYY for Europe?

yes, of course. i meant to pick the gb format and thought the us had inherited from gb

 

[2stein]

thinking again and again, i came to the conclusion that the benefit of my proposal is too small for what we already have... it would not fundamentally change things. so, it's not worth the effort.

 

[Huevos]

        <widget source="Event" render="Label" position="930,105" size="120,36" backgroundColor="background" transparent="1" foregroundColor="secondFG" font="Regular;33" halign="right" valign="top">
            <convert type="EventTime">StartTime</convert>
            <convert type="ClockToText"/>
        </widget>
        <widget source="Event" render="Label" position="1050,105" size="120,36" backgroundColor="background" transparent="1" foregroundColor="secondFG" font="Regular;33" halign="left" valign="top">
            <convert type="EventTime">EndTime</convert>
            <convert type="ClockToText">Format: - %H:%M</convert>
        </widget>

I found that by accident. The start time follows the user settings and the end time follows the format. I only found it because I was trying the user settings.

 

[2stein]

the design seems a little strange. Format is used to just add the hyphon.
however it works because in all languages %H:%M is correct and thus doesn't need translation.

 

[Huevos]

Should be %H%M in both places otherwise the user can change the format and we end up with something like "2.00pm - 14:30".

Also using format means as a skinner the item will always fit in the allocated space.