[OS-mini] Empty buttons (no text) in timer and sanity error views

[dsayers]

Maybe @KiddaC can put his Skins on Github then maybe users can make pull request to try and help? This way both teams/skinners can see the code and how it works. Because I don't have a clue lol

 

[kiddac]

Grrrrr. My skin wont work fine. How are you not getting this Heuvos. It may work fine on openvix, but it won't work fine on openatv or any other oe-alliance build that hasn't implemented these stupid changes.

For example. TimerEdit.py.
Screen "TimerEditList".
Histroically has always been.

self["key_red"] = Button(" ")
self["key_green"] = Button(_("Add"))
self["key_yellow"] = Button(" ")
self["key_blue"] = Button(" ")

Therefore you use something like this
<widget name="key_red" position="45,0" size="237,38" font="Regular;30" valign="center" transparent="1" noWrap="1" foregroundColor="white" backgroundColor="button-bg" halign="left" />


And get it displayed like this.



Now if I just change it to the source buttons, you get.



For the very reason you have been harping on about it in the other thread. The buttons are populated via settext. Which means source button code doesn't work for self["key_red"] = Button(" ").

So we get no buttons and we certainly don't get the text switch between enable/disable timers.

 

[Huevos]

And that problem is because you not using source="label". It is nothing to do with the objecttypes attribute.

 

[kiddac]

FFS my source button code is

<widget source="key_red" render="Label" position="45,0" size="237,38" font="Regular;30" valign="center" transparent="1" noWrap="1" foregroundColor="white" backgroundColor="button-bg" halign="left" />

You changing the code to

self["key_red"] = StaticText("")
self["key_green"] = StaticText(_("Add"))
self["key_yellow"] = StaticText("")
self["key_blue"] = StaticText("")

has broken every skin accept vix skins. Simple as that.

 

[kiddac]

At least littlesat had some common sense on that other thread. But like you are doing here. You refused to listen to him and just kept talking over him. You are refusing to listen to me.
You just don't get the fact, you have broken everyones skins and you just dont care.

 

[Huevos]

FFS my source button code is

<widget source="key_red" render="Label" position="45,0" size="237,38" font="Regular;30" valign="center" transparent="1" noWrap="1" foregroundColor="white" backgroundColor="button-bg" halign="left" />

You changing the code to

self["key_red"] = StaticText("")
self["key_green"] = StaticText(_("Add"))
self["key_yellow"] = StaticText("")
self["key_blue"] = StaticText("")

has broken every skin accept vix skins. Simple as that.

No it is broken in skins that don't properly support our enigma code. It is up to you if you choose to withdraw support for your users that are using OpenViX, but demanding that our enigma is identical to OpenATV's and must never be edited is ridiculous.

 

[kiddac]

So I will quote your post 294

My suggestion is leave the old names for a while and just add new names. After a couple of months remove the old names. This gives the skinners time to catch up. After that time delete the old names, and start switching some Button and Label objects to StaticText. But in my opinion it is not fair to just break everyone's skins, especially when some skins are shared between images.

The day after you decide to change all vix code. You really do talk a lot of crap. And still wont admit you have messed this up big time.

 

[Huevos]

The day after you decide to change all vix code. You really do talk a lot of crap. And still wont admit you have messed this up big time.

Completely out of context. That quote refers to variable names.

i.e. when a variable had a non-standard name. The old name was left in place for backwards compatibility and the new "standard" name was added.
e.g. https://github.com/oe-alliance/oe-alliance-plugins/commit/cf1ecddcf825f2d9e1a29de76dce2f5c32710bc6

With that commit it now works in any skin using either name. And from that commit anyone can see that I do respect the skinners.

 

[kiddac]

If it was such a good idea to amend the button code for timers, why haven't you amended all the other button codes for all the other screens?
Just a question.

 

[Huevos]

Just haven't got round to it yet. Obviously screens that could benefit from dynamic PNGs come first.