EPG files test: Phase 1. Refactor

[seagen]

Thank you for taking care of it its an exellent fix for a long time issue and as a skinner i can say you just saved us from lots of work in the future.
I am using OpenBlackhole but image is built on the VIX core so we need to add our own setup.xml and UsageConfig.py but i have allredy fixed that
so really hope this goes into the next VIX update

 

[IanSav]

Hi,

Is this the appropriate way to fix the issue? Given that the font sizes are adjustable varying the number of characters would seem to be the wrong way to restore columnar alignments.

I suggest a better way to fix this would be to add skin parameters that define the widths of the columns to ensure that no matter what the skin the columns can be made to align.

Regards,
Ian.

 

[bbbuk]

Hi Ian,

I have replied back to this comment in the PR.

 

[IanSav]

Hi Bbbuk,

That pull request has been closed so I will copy my reply here.

I was proposing that there could be a skin parameter with three width settings one width for the service column, one for the progress or event times and one for the event name. Once the column widths are defined then the text in each column will naturally be truncated when the text string exceeds the allocated column width. There is no need to set or play with the actual string lengths themselves. By specifying the column widths as parameters in the skin the columns can be adjusted and aligned to match the visual design of each skin.

Regards,
Ian.

 

[ccs]

Not sure if this is the right section, but I'm sure the autotimer popup used to say "2 Timers were added", not "2 Timer were added" as it does now.

 

[Joe_90]

Programmer from Yorkshire, maybe

 

[simonc]

Haha, very good

The text from that popup is in AutoTimer. It doesn't really do plurals!

 

[Valiant]

Programmer from Yorkshire, maybe

HaHa, a true Yorkshire programmer might make use of sheep counting lingo - Yan, Tan, Tethera and so on for the cardinals, so the message might read "tan timer were added", then the rest of the UK would need a translation package

 

[ccs]

If this is the version of autotimer that ViX uses

https://github.com/oe-alliance/enigma2-plugins/blob/master/autotimer/src/AutoTimer.py

then it's been "2 timer were added" for a long time. At least it doesn't say "2 timer was added".

 

[Joe_90]

Is it not possible to construct a condition to print " one timer was added" or "two timers were added" etc?

 

[Valiant]

Is it not possible to construct a condition to print " one timer was added" or "two timers were added" etc?

Or just lose the past tense - "x timer(s) added"