OpenVIX bug causing crashes

[abu baniaz]

[strike]
@Headbanger, if you do not have IPTV, can you upload your bouquet files please? Everything ending in .tv and .radio in /etc/enigma2. Zip them please. Can you also attach the file called settings in the same directory.
[/strike]

 

[Huevos]

@Headbanger, if you do not have IPTV, can you upload your bouquet files please? Everything ending in .tv and .radio in /etc/enigma2. Zip them please. Can you also attach the file called settings in the same directory.

Nothing to do with the bouquet files.

 

[Huevos]

Menu > Setup > UI > CS.

Disable "multiple bouquets". Enable "panic button". Save and exit menu. Zap to another channel. Press "zero" twice. Crash.

 

[abu baniaz]

Receiver wont boot for me now

<  3414.4946> 00:50:49.2769   File "/usr/lib/enigma2/python/mytest.py", line 44, in <module>
<  3414.4948> 00:50:49.2771     from Screens import InfoBar
<  3414.4949> 00:50:49.2772   File "/usr/lib/enigma2/python/Screens/InfoBar.py", line 5, in <module>
<  3414.4951> 00:50:49.2774   File "/usr/lib/enigma2/python/Screens/MovieSelection.py", line 11, in <module>
<  3414.4953> 00:50:49.2776   File "/usr/lib/enigma2/python/Components/PluginComponent.py", line 7, in <module>
<  3414.4954> 00:50:49.2778 ImportError: No module named Plugins.Plugin

 

[Huevos]

Have you deleted it by accident?

/usr/lib/enigma2/plugins/plugin.py

 

[Huevos]

https://github.com/OpenViX/enigma2/commit/b1921562622247cc0e586698542655aabb53ac43

Not able to test fully. For me the loop aborts on line 1048 on the first iteration.

No idea what this is supposed to do or if it has ever worked.

 

[ccs]

https://github.com/OpenViX/enigma2/commit/b1921562622247cc0e586698542655aabb53ac43

Not able to test fully. For me the loop aborts on line 1048 on the first iteration.

No idea what this is supposed to do or if it has ever worked.

I went back to 5.3.001 and it crashed as well...

<   100.960> [InfoBarGenerics] KEY: 11 0
<   100.961> [eDVBServicePlay] timeshift
<   100.962> Traceback (most recent call last):
<   100.962>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 72, in action
<   100.962>   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1001, in keyNumberGlobal
<   100.963>   File "/usr/lib/enigma2/python/Components/Timeshift.py", line 492, in checkTimeshiftRunning
<   100.963>   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1026, in recallPrevService
<   100.963> AttributeError: 'InfoBar' object has no attribute 'service_types'
<   100.964> [ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap instance at 0x726cd238>>,('NumberActions', '0')) failed)

 

[Huevos]

I went back to 5.3.001 and it crashed as well...

<   100.960> [InfoBarGenerics] KEY: 11 0
<   100.961> [eDVBServicePlay] timeshift
<   100.962> Traceback (most recent call last):
<   100.962>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 72, in action
<   100.962>   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1001, in keyNumberGlobal
<   100.963>   File "/usr/lib/enigma2/python/Components/Timeshift.py", line 492, in checkTimeshiftRunning
<   100.963>   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1026, in recallPrevService
<   100.963> AttributeError: 'InfoBar' object has no attribute 'service_types'
<   100.964> [ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap instance at 0x726cd238>>,('NumberActions', '0')) failed)

Yes, it will crash. That code is years old. Just shows how few users use anything than the default setup. New commit avoids the crash but I have no clue what the intended behaviour was, nor if it ever worked or was tested. As soon as the first crash was fixed it caused a second crash further down (which is also fixed). But for me the loop aborts on line 1048. This maybe related to the content of my bouquets but without knowing the intention of the person who wrote this code I have no clue what is supposed to happen.

 

[abu baniaz]

Have you deleted it by accident?

/usr/lib/enigma2/plugins/plugin.py

Yes. Thanks.


I normallly run these scripts to create symlinks for easy access. Seems doing it twice has an issue.

ln -s /usr/lib/enigma2/python/Plugins /_Plugins
ln -s /usr/lib/enigma2/python/Plugins/Extensions /_Extensions
ln -s /usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker /_ABM
ln -s /usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/providers /_ABM_providers
ln -s /usr/lib/enigma2/python /_Python
ln -s /usr/share/enigma2/Simple_Ten_Eighty /_Simple1080
ln -s /usr/share/enigma2 /_Skins
ln -s /usr/lib/enigma2/python/Plugins/SystemPlugins/ViX /_Vix

 

[simonc]

https://github.com/OpenViX/enigma2/commit/b1921562622247cc0e586698542655aabb53ac43

Not able to test fully. For me the loop aborts on line 1048 on the first iteration.

No idea what this is supposed to do or if it has ever worked.

Breaks for me here with the instructions you posted below. Looks to be copy and pasted code from somewhere else and has probably never worked.

 

[Huevos]

Breaks for me here with the instructions you posted below. Looks to be copy and pasted code from somewhere else and has probably never worked.

It's a section of code I am not familiar with. With what I committed the crash was gone. ATV have something very similar but when I tried it I just got trapped with the backdrop screen and a greyed out infobar.

So can we figure out what is the correct behaviour/logic for those config settings? Personally I have always had multi-bouquets enabled.

 

[simonc]

At the risk of complicating the discussion, what is the point of single bouquet mode? Which actual bouquet is single bouquet mode meant to use? And why does the UI, when in this mode, still display things like the bouquet lists when opening EPGs, the favourites button in the channel list? If I only wanted a single bouquet, I'd just delete ones I don't want. Or is it intended as a temporary switch that you might activate when you've got visitors and you don't want them confused?

 

[ccs]

This is probably the commit which set up multi-bouquets, 14 years ago!

https://github.com/OpenViX/enigma2/commit/92c581769db1ebef1325d175e3b610be25317af1

also

https://github.com/OpenViX/enigma2/commit/51845a7b8ea8bad523b083d1564e1b907fbdc84e

https://github.com/OpenViX/enigma2/commit/f3828b4fde4d61d9bb19eee7e92e2f566af6c391

 

[Huevos]

At the risk of complicating the discussion, what is the point of single bouquet mode?

No clue. If you disable multiple bouquet mode you remain in the currently active bouquet. If you leave the current bouquet (e.g. press UP or DOWN on the 4 way button and then go into the ALL or Satellite list and then zap to a channel) it is then impossible to return to any bouquet.

From viewing a channel, press UP/DOWN, then BLUE for favourites/bouquets, the bouquet list is empty.

If you are in a bouquet and you select GEPG and then the TV button it just displays current bouquet.

I can't find any way to re-enter any bouquet once I have left the active bouquet. Hmm, I think said that already.

TBH, I think InfoBarGenerics.py and ChannelSelection.py need a complete rewrite. In the context of the way current image works this code seems like complete junk that serves no useful purpose, and that can only lead to threads on the forum such as this one.

My personal opinion is until this is code is re-written/removed, config.usage.multibouquet should be removed from setup.xml and config.usage.multibouquet forced to "yes" in UsageConfig.py.

What do you think.

 

[simonc]

Yes. I'd suggest removing single bouquet mode. I only ever use a single custom bouquet - there's not really enough channels on UK terrestrial to warrant multiple bouquets - and I've never used this option. If you only want a single bouquet, you can choose to not create more than one!

If you want the whole lot gone, I'm happy to get the hatchet out.

EDIT: It's referred to by many plugins, AutoTimer and EPGSearch included

 

[Huevos]

If you want the whole lot gone, I'm happy to get the hatchet out.

EDIT: It's referred to by many plugins, AutoTimer and EPGSearch included

That doesn't stop us from removing it in enigma if we want to do that. It just means we need to retain the variable (in UsageConfig.py).

Maybe we should start a thread in the Dev area to discuss further or find if anyone else has useful input or knowledge of what this is supposed to do. Otherwise I am just going to disable it for the time being.

 

[abu baniaz]

Alternative numbering is for making all bouquets start at 1
Disabling multi bouquets implies, (or at least should) ensure you only have one bouquet. This should mean alternative numbering is not applicable.

However, I don't see how disabling multi-bouquets can work properly. What should happen to the last scanned bouquet after you perform a scan?

 

[Huevos]

I think it is old code, not used by anyone for years and completely out of step with how a modern image works. And like Simon says if you only have one bouquet (or none) enigma still works fine with multi bouquets enabled.

 

[simonc]

It appears that before bouquets there was a concept of a single list of favourites.

 

[abu baniaz]

Probably. Scan and then add to favourites. One of my first posts here involved enabling multiple bouquets in Dreambox edit. The TM800HD had a sharp SOC and not had a box with picture quality like it since. Either that or my eyesight is not what it was.