EPG files test: Phase 1. Refactor

[bbbuk]

ok, no crash but don't know if it's just mine but based on EPG files in post 2, I'm getting error going into plugin menu:

Warning

Some plugins are not available:
Extensions/IMDb (cannot import name: EPGBouquetList)
Extensions/EPGSearch (cannot import name: EPGBouquetList)

I tried installing plugins but it states they are installed and up-to-date!

 

[simonc]

Ah, looks like we're missing a couple of files from the zip. Abu can you add EPGSelection and EPGList into it and reupload? Those 2 files are what maintain compatibility with the plugins. Avoid getting the commit from this morning though, that's got a bunch of rename changes that might confuse matters.

 

[goRtstill]

You're meant to use FileZilla or some such to transfer the files within the zip to your device having first backed the files up as per post #2)

ok, no crash but don't know if it's just mine but based on EPG files in post 2, I'm getting error going into plugin menu:



I tried installing plugins but it states they are installed and up-to-date!

Ah, looks like we're missing a couple of files from the zip. Abu can you add EPGSelection and EPGList into it and reupload? Those 2 files are what maintain compatibility with the plugins. Avoid getting the commit from this morning though, that's got a bunch of rename changes that might confuse matters.

 

[bbbuk]

You're meant to use FileZilla or some such to transfer the files within the zip to your device having first backed the files up as per post #2)

I followed what was mentioned in post 2 but two files aren't included in that zip and according to simonc, these files are what are needed to maintain compatibility with plugins.

 

[goRtstill]

I followed what was mentioned in post 2 but two files aren't included in that zip and according to simonc, these files are what are needed to maintain compatibility with plugins.

I've re-read

 

[abu baniaz]

I have re-uploaded the attchment. Sorry for the error.

bbbuk is one the original people involved in the coloured buttons mod. It is based on his work and obstalces he encountered, that this tidy-up/untangling project was started.

 

[ronand]

I finally got around to do a bit of testing.

Trying to bring up the single epg now causes a crash

Also epg search is causing a crash

Debug logs attached

 

[abu baniaz]

Thanks for testing and reporting. Please note my fubar with the earlier attachment. However, I can confirm the crash for EPG Search, but not single EPG.

That single EPG name has two contexts, that is why there was the renaming this morning. Updated files will be uploaded after fixing the crashes you reported. Can you give step by step guide to reproduce the single EPG crash please. I normally just press red.

'SimpleSummary'.
< 68113.803> Traceback (most recent call last):
< 68113.803>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 328, in startUp
< 68113.803>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 337, in refreshlist
< 68113.803>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 578, in searchEPG
< 68113.803>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 603, in startSearchEPG
< 68113.803>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 163, in recalcEntrySize
< 68113.803> AttributeError: 'EPGSearchList' object has no attribute 'eventFontSizeSingle'
< 68113.803> [ePyObject] (CallObject(<bound method EPGSearch.startUp of <class 'Plugins.Extensions.EPGSearch.EPGSearch.EPGSearch'>>,()) failed)

EDIT:
Fixed here
https://github.com/SimonCapewell/enigma2/commit/a55b4dbc6dcbf8241b0ad3d1c37d7cbef8236fe2

 

[bbbuk]

Ok, added the new refreshed files for post 2 and plugin menu ok.

Tested EPGSearch within GEPG screen and it crashed as mentioned by @ronand

Believe this being reason:

<   655.056> AttributeError: 'EPGSearchList' object has no attribute 'eventFontSizeSingle'

Looks like eventFontSizeSingle isn't found!

How to re-create:
1. Within GEPG screen
2. Yellow button (EPG Search)

EPG Search comes up for few seconds like it's trying, nothing is displayed but then crashes.


Mod Edit:
Fixed here
https://github.com/SimonCapewell/enigma2/commit/a55b4dbc6dcbf8241b0ad3d1c37d7cbef8236fe2

 

[ronand]

I usually bring up my channel list using the up or down arrow. Then to get single epg on a particular channel I press either the "i" button or "epg" - both do the same thing on the sf8008. Red button works (I never knew that was there so wont start using it now!)

Mod EDIT:
Fixed here
https://github.com/SimonCapewell/enigma2/commit/ac41ed88018d7ad44a97b7f795c9f27c666590f8

 

[abu baniaz]

Thanks for the reproduction step. I don't normally activate it that way, but will start using it for the test. May even make its way into the navigation guide. I can confirm crash too.

Press up to invoke Channel list, select any channel, Press Info or GUIDE, results in a crash

< 69649.151> [InfoBarGenerics] KEY: 358 INFO
< 69649.151> [ActionMap] Keymap 'ChannelSelectEPGActions' -> Unknown action 'info'! (Typo in keymap?)
< 69649.151> [ActionMap] Keymap 'ChannelSelectEPGActions' -> Action = 'showEPGList'.
< 69649.153> Traceback (most recent call last):
< 69649.153>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
< 69649.153>   File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 946, in showEPGList
< 69649.153>   File "/usr/lib/enigma2/python/mytest.py", line 329, in openWithCallback
< 69649.153>     dlg = self.open(screen, *arguments, **kwargs)
< 69649.153>   File "/usr/lib/enigma2/python/mytest.py", line 339, in open
< 69649.154>     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
< 69649.154>   File "/usr/lib/enigma2/python/mytest.py", line 276, in instantiateDialog
< 69649.154>     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
< 69649.154>   File "/usr/lib/enigma2/python/mytest.py", line 299, in doInstantiateDialog
< 69649.154>     dlg = screen(self, *arguments, **kwargs)
< 69649.154> TypeError: __init__() got an unexpected keyword argument 'serviceChangeCB'
< 69649.154> [ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap instance at 0xb0b481c0>>,('ChannelSelectEPGActions', 'showEPGList')) failed

EDIT:
Fixed here: https://github.com/SimonCapewell/enigma2/commit/ac41ed88018d7ad44a97b7f795c9f27c666590f8

 

[simonc]

Thanks for those 2. I've got fixes on the way for them

 

[abu baniaz]

The two crashes have been fixed. Thanks Simon. I have edited posts above with links to fixes. I have uploaded the attachment in post 1. Hopefully without errors. If you have tested previous files, please delete the older Epg folders first. Otherwise redundant files will remain.

Thank you for your continued tests, feedback and assistance.

 

[ronand]

Those fixes seem to have worked. However I've spotted something else when using EPG Search - The channel name is now transposed over the satellite position as in the attached image. The skin is Magic FHD but I dont think that is the issue as it works fine on the regular 5.3.020 build

View attachment 59889

Mod EDIT
Fixed here. Thanks for reporting
https://github.com/SimonCapewell/enigma2/commit/7e48c5ad1119851f66d048aa62723633a92dda8f

 

[bbbuk]

I have same as mentioned by @Ronand

Even though I didn't think it was related to skin, I did try two different skins. Same thing....

View attachment 59890

 

[simonc]

Another bug squashed

 

[abu baniaz]

This is the modified file to fix the overlap. I'll upload the attachemnt inpost 1 to include it.

 

[abu baniaz]

Another bug squashed

That has introduced another.

Steps:
EPG/Guide to invoke Grid EPG (Graphics)
Yellow for EPG search

<  9926.369> [EPGSelectionGrid] ------- NEW VERSION -------
<  9926.370> [EPGSelectionBase] 5
<  9926.373> [EPGListGrid] Init
<  9926.373> [EPGListBase] Init
<  9926.379> [Skin] Processing screen 'GraphicalEPGPIG' from list 'GridEPGPIG, GraphicalEPGPIG', position=(0, 0), size=(1280 x 720) for module 'EPGSelectionGrid'.
<  9926.394> [GUISkin] warning, skin is missing element number in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.395> [GUISkin] warning, skin is missing element jump in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element page in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element primetime in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline0 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline2 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline3 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline1 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline4 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.397> [GUISkin] warning, skin is missing element timeline5 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.398> [GUISkin] warning, skin is missing element change_bouquet in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.410> [Skin] Processing screen 'GraphicalEPGPIG_summary' from list 'GridEPGPIG_summary, GraphicalEPGPIG_summary, SimpleSummary', position=(0, 0), size=(220 x 176) for module 'SimpleSummary'.
<  9927.821> [eInputDeviceInit] 1 190 1
<  9927.821> [InfoBarGenerics] KEY: 400 YELLOW
<  9928.020> [eInputDeviceInit] 0 190 1
<  9928.020> [InfoBarGenerics] KEY: 400 YELLOW
<  9928.020> [ActionMap] Keymap 'ColorActions' -> Action = 'yellow'.
<  9928.026> Traceback (most recent call last):
<  9928.026>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
<  9928.026>   File "/usr/lib/enigma2/python/Screens/Epg/EpgSelectionBase.py", line 29, in fn
<  9928.026>     action()
<  9928.026>   File "/usr/lib/enigma2/python/Screens/Epg/EpgSelectionBase.py", line 202, in openEPGSearch
<  9928.026>     self.session.open(EPGSearch, name, False)
<  9928.026>   File "/usr/lib/enigma2/python/mytest.py", line 339, in open
<  9928.027>     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
<  9928.027>   File "/usr/lib/enigma2/python/mytest.py", line 276, in instantiateDialog
<  9928.027>     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
<  9928.027>   File "/usr/lib/enigma2/python/mytest.py", line 299, in doInstantiateDialog
<  9928.027>     dlg = screen(self, *arguments, **kwargs)
<  9928.027>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 238, in __init__
<  9928.027>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 60, in __init__
<  9928.027>   File "/usr/lib/enigma2/python/Components/EpgList.py", line 39, in __init__
<  9928.027>     EPGListSingle.__init__(self, config.epgselection.single, selChangedCB, timer)
<  9928.027>   File "/usr/lib/enigma2/python/Components/config.py", line 1884, in __getattr__
<  9928.027> AttributeError: single
<  9928.028> [ePyObject] (CallObject(<bound method HelpableActionMap.action of <Components.ActionMap.HelpableActionMap instance at 0xafda92b0>>,('ColorActions', 'yellow')) failed)

EDIT @16:50:
Fixed here https://github.com/SimonCapewell/enigma2/commit/1c0b2a3b24d8b711259abd58b2a5c56faf301a57
Post 1 updated with newer files.

 

[simonc]

Bah! That's by the EPG naming and config cleanup task getting in the way. It's time to bite the bullet and commit those changes too, rather than continue to juggle things.

Just a warning that these updates include changes to setup.xml and menu.xml and will start using a new set of configuration values, so the new EPGs will use default settings. The old settings seem to be persisted so if you revert back to the current EPG, then things are still as you left them.

 

[bbbuk]

As it objects to use of 'single', if u revert just line 39 from epglist.py back to what it was, I've been able to get mine working again...

View attachment 59896

Looks okay (as in not overlap or even crashing). Don't know of any unintended consequence of that!