EPG files test: Phase 1. Refactor

[abu baniaz]

Version 4 attached to first post. Please note the amended instructions with regards to the two xml files.

Sorry for the trouble and inconvenience. Thanks once again

 

[abu baniaz]

An quirk/oddity that may affect receivers that do not have EPG button and only the Info button.

EPG button to Invoke Grid EPG.
Info button invokes EventView'
EPG button invokes Single EPG

In channel selection screen, both buttons instigate Single EPG (the one that you can change services)

Note: I am testing with Vix Night HD

 

[dsayers]

In GraphicalEPG changing Service Title mode between "Picon, Service Number and Service Name" or "Service Number, Picon and Service Name" seems to always show Picon, Service Number and Service Name.

Same with "Service Number and Picon" or "Picon and Service Number" it always shows Picon and Service Number.

Mod Edit
Fixed with: https://github.com/SimonCapewell/enigma2/commit/34fafedfb6378321b7549a3de636dae34c90de77
Upload in post 1 contains fix

 

[ccs]

Up and running with the latest version (the one including the xml files).

So far so good, it took about 3 minutes to set up the box the same as I had previously configured it.

(FWIW it took me more than 3 hours to get the epg working on the box when starting from scratch last week. The epg/guide button insisted on taking make straight to "all channels", when I'd supposedly set it up to show bouquets on launch. Reboots, restarting GUI, waiting for the epg to populate, made no difference. And then, as if by magic, it started working.
I hope abu isn't reading this.)

 

[bbbuk]

Just updated to v4 and ok so far

@Abu you may wish to update post 1 to say some settings may need to be reset again

 

[ccs]

There's a small indicator that you're on the new EPG. I've capitalised the coloured button labels, so if it says Add Timer Add AutoTimer then you're on the new EPG. The old one is Add timer Add Autotimer

I guess I'd better ask this question, lower case and capitals are getting mixed up in the post.

The reason I'm mentioning it is because I'm not seeing capitalised coloured buttons.

 

[bbbuk]

I guess I'd better ask this question, lower case and capitals are getting mixed up in the post.

The reason I'm mentioning it is because I'm not seeing capitalised coloured buttons.

I do on mine, at least in graphical EPG view.

My last screenshot (here) will show what it should look like.

 

[simonc]

I'm afraid that advice was fairly short lived. Ignore it now, you're on the new EPG regardless of recording or not. The old code is gone

In GraphicalEPG changing Service Title mode between "Picon, Service Number and Service Name" or "Service Number, Picon and Service Name" seems to always show Picon, Service Number and Service Name.

That was a set of new options that wasn't meant to be included yet. I've just added the corresponding feature in the Grid EPG

An quirk/oddity that may affect receivers that do not have EPG button and only the Info button.

EPG button to Invoke Grid EPG.
Info button invokes EventView'
EPG button invokes Single EPG

There's options in the EPG for the behaviour of Info/Info long press, so this shouldn't be a problem.

 

[simonc]

BTW, I'm also interested in how disruptive losing your EPG view options are. We can add an upgrade migration if people think it's a pain.

 

[ccs]

I do on mine, at least in graphical EPG view.

My last screenshot (here) will show what it should look like.

I don't see coloured buttons labelled in capitals , but I do see "Grid EPG" in the EPG setup menu, which I assume means I've set it up ok.

Your screenshot is very skin dependent.

 

[ccs]

I know this isn't very helpful, but the problem I mentioned in #44 came back again when I went into the grid epg while watching a recording.

It went straight to "ALL", no bouquet list, and I couldn't resolve it until I rebooted the box.

I can't reproduce it (yet).

 

[bbbuk]

I don't see coloured buttons labelled in capitals , but I do see "Grid EPG" in the EPG setup menu, which I assume means I've set it up ok.

Your screenshot is very skin dependent.

If you look at blue button option it should read, "Add AutoTimer". This is what I believe is meant (ie initial capitals) as I'm sure original code was "Add Autotimer"

My screenshot is not skin dependent but is EPG screen dependent. Basically I mostly use Graphical EPG and infobars. I don't know if this initial capitals is on other EPG screens which I should have said. Sorry

 

[simonc]

when I went into the grid epg while watching a recording.
It went straight to "ALL", no bouquet list, and I couldn't resolve it until I rebooted the box.

It might be related to watching a recording. There may be an issue with it not remembering the bouquet in use before starting to watch the recording, and it may just be defaulting to All

 

[ccs]

It might be related to watching a recording. There may be an issue with it not remembering the bouquet in use before starting to watch the recording, and it may just be defaulting to All

That would explain it, I guess, but it gets stuck after I stop the recording and go back into the epg, no bouquet list shown.

 

[ccs]

Found a way to crash the box.

Start watching a recorded program, press epg and select a bouquet, highlight a tv program and press ok.

The sound of live tv comes on, but the epg still remains on screen. Ok button returns to live tv, but exit crashes the box.

<  5469.460> [InfoBarGenerics] KEY: 174 EXIT
<  5469.460> [ActionMap] Keymap 'OkCancelActions' -> Action = 'cancel'.
<  5469.460> Traceback (most recent call last):
<  5469.460>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
<  5469.460>   File "/usr/lib/enigma2/python/Screens/Epg/EpgSelectionBase.py", line 481, in closeScreen
<  5469.461>     if self.epgConfig.previewmode.value:
<  5469.461>   File "/usr/lib/enigma2/python/Components/config.py", line 1884, in __getattr__
[B]<  5469.461> AttributeError: previewmode[/B]
<  5469.461> [ePyObject] (CallObject(<bound method HelpableActionMap.action of <Components.ActionMap.HelpableActionMap instance at 0x9dbf8f58>>,('OkCancelActions', 'cancel')) failed)

Mod Edit:
Fixed here: https://github.com/SimonCapewell/enigma2/commit/51b5568f464e59eb0b776661a250c2f5dc00bdde
Upload in post 1 contains fix.

 

[ccs]

....... added log to previous post.

 

[abu baniaz]

BTW, I'm also interested in how disruptive losing your EPG view options are. We can add an upgrade migration if people think it's a pain.

If it is easy to do, please add. That way users won't feel any change

BTW, there was long standing bug/issue. If there is no picon, the space is not reserved. The fix was to use a zero bit default picon. Is that an easy win?

EDIT: Fixed here
https://github.com/SimonCapewell/enigma2/commit/9e97ee42d7dc0587736d2dbd71d99d46599db62b

Upload in post 1 contains fix

 

[abu baniaz]

Up and running with the latest version (the one including the xml files).

So far so good, it took about 3 minutes to set up the box the same as I had previously configured it.

(FWIW it took me more than 3 hours to get the epg working on the box when starting from scratch last week. The epg/guide button insisted on taking make straight to "all channels", when I'd supposedly set it up to show bouquets on launch. Reboots, restarting GUI, waiting for the epg to populate, made no difference. And then, as if by magic, it started working.
I hope abu isn't reading this.)

This probably part of the "lost focus" issue that I'd like to get fixed.

The all services group, does not have any sub-directories, so you cannot navigate anywhere else. Might be an idea to use channel selection system then enter EPG system if you have lost bearings.

I use the All quite regualarly as I can jump easily from a satellite service to a Terrestrial one with same/similar name.

 

[abu baniaz]

Found a way to crash the box.

Start watching a recorded program, press epg and select a bouquet, highlight a tv program and press ok.
The sound of live tv comes on, but the epg still remains on screen. Ok button returns to live tv, but exit crashes the box.

I can confirm this crash too. But for me, once you select a channel, it starts playing, just wait and it then crashes. Same errors about the preview attribute.

 

[simonc]

Found a way to crash the box.
Start watching a recorded program, press epg and select a bouquet, highlight a tv program and press ok.
The sound of live tv comes on, but the epg still remains on screen. Ok button returns to live tv, but exit crashes the box.

Thanks, this is now fixed

there was long standing bug/issue. If there is no picon, the space is not reserved. The fix was to use a zero bit default picon. Is that an easy win?

Yes an easy win. Fix now in the branch